-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: change 'Physcial Replication Producer' category to 'Replication Producer' #127374
Merged
craig
merged 3 commits into
cockroachdb:master
from
msbutler:butler-remove-physical-label
Jul 18, 2024
Merged
ui: change 'Physcial Replication Producer' category to 'Replication Producer' #127374
craig
merged 3 commits into
cockroachdb:master
from
msbutler:butler-remove-physical-label
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbutler
added
T-disaster-recovery
backport-24.2.x
Flags PRs that need to be backported to 24.2
labels
Jul 17, 2024
…roducer' Epic: none Release note: none
msbutler
force-pushed
the
butler-remove-physical-label
branch
from
July 17, 2024 18:06
7b8691d
to
266c014
Compare
msbutler
changed the title
Butler remove physical label
ui: change 'Physcial Replication Producer' category to 'Replication Producer'
Jul 17, 2024
Epic: none Release note: none
msbutler
force-pushed
the
butler-remove-physical-label
branch
from
July 18, 2024 01:07
11d1202
to
520dad7
Compare
stevendanna
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
TFTR! bors r=stevendanna |
Build failed: |
bors r- |
msbutler
force-pushed
the
butler-remove-physical-label
branch
2 times, most recently
from
July 18, 2024 15:45
dd9d1cc
to
b6204b6
Compare
The patch avoids showing the fraction completed on the jobs page for LDR because it doesn't mean anything. Epic: none Release note: none
msbutler
force-pushed
the
butler-remove-physical-label
branch
from
July 18, 2024 16:11
b6204b6
to
8e7952d
Compare
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: none
Release note: none